fix crash when the expression exceed the depth #3606

heroicNeZha · 2021-12-30T05:52:27Z

What type of PR is this?

bug
feature
enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

# when the expression exceed the depth
[ERROR (-1004)]: SyntaxError: The above expression is not a valid expression, because its depth exceeds the maximum depth! near `1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+'

calcate the depth in parser through BFS

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

Documentation affected (Please add the label if documentation needs to be modified.)
Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

yixinglu · 2021-12-30T06:56:36Z

src/parser/parser.yy

+ : expression_internal {
+ $$ = $1;
+ if(!graph::ExpressionUtils::checkExprDepth($$)){
+ throw nebula::GraphParser::syntax_error(@1, "The above expression's depth exceeds the maximum depth!");


need to delete this $$ before throw exception

The above expression's depth exceeds the maximum depth: 512!

ExpressionUtils::kMaxDepth

…to expression_depth_3

src/graph/util/ExpressionUtils.cpp

jievince

LGTM

…to expression_depth_3

heroicNeZha

without depth check

============================================================================
/home/nebula/nebula/src/parser/test/ParserBenchmark.cpprelative  time/iter  iters/s
============================================================================
SimpleQuery(1_thread)                                       16.69us   59.93K
SimpleQuery(2_thread)                             99.27%    16.81us   59.49K
SimpleQuery(4_thread)                             99.38%    16.79us   59.56K
SimpleQuery(8_thread)                             99.17%    16.83us   59.43K
SimpleQuery(16_thread)                            99.00%    16.86us   59.33K
SimpleQuery(32_thread)                            95.46%    17.48us   57.21K
SimpleQuery(48_thread)                            86.43%    19.31us   51.80K
----------------------------------------------------------------------------
ComplexQuery(1_thread)                                      75.65us   13.22K
ComplexQuery(2_thread)                            99.68%    75.90us   13.18K
ComplexQuery(4_thread)                            99.51%    76.03us   13.15K
ComplexQuery(8_thread)                            99.51%    76.02us   13.15K
ComplexQuery(16_thread)                           98.88%    76.51us   13.07K
ComplexQuery(32_thread)                           95.30%    79.38us   12.60K
ComplexQuery(48_thread)                           85.81%    88.17us   11.34K
============================================================================

add depth check

============================================================================
/home/nebula/nebula/src/parser/test/ParserBenchmark.cpprelative  time/iter  iters/s
============================================================================
SimpleQuery(1_thread)                                       16.49us   60.65K
SimpleQuery(2_thread)                             99.38%    16.59us   60.27K
SimpleQuery(4_thread)                             99.22%    16.62us   60.17K
SimpleQuery(8_thread)                             99.20%    16.62us   60.16K
SimpleQuery(16_thread)                            98.25%    16.78us   59.58K
SimpleQuery(32_thread)                            95.33%    17.30us   57.81K
SimpleQuery(48_thread)                            85.46%    19.29us   51.83K
----------------------------------------------------------------------------
ComplexQuery(1_thread)                                      79.23us   12.62K
ComplexQuery(2_thread)                            99.81%    79.38us   12.60K
ComplexQuery(4_thread)                            99.88%    79.32us   12.61K
ComplexQuery(8_thread)                            99.85%    79.35us   12.60K
ComplexQuery(16_thread)                           99.28%    79.80us   12.53K
ComplexQuery(32_thread)                           96.18%    82.37us   12.14K
ComplexQuery(48_thread)                           84.38%    93.90us   10.65K
============================================================================

* Fix typos (#3615) Co-authored-by: kyle.cao <kyle.cao@vesoft.com> * fix fetch edges tostring (#3613) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> * fix create space assign offline host (#3583) * fix create space * fix test case Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> * Disable ARM version docker image since related third party not ready (#3618) * Unify raft error code (#3620) * Meta upgrader v3 (#3540) * Replace group when create space * Support white list * fix test case * support zone operations * fix * Support meta upgrade v3 * add more check about parse host result (#3628) * Ut fix (#3611) * Enable ut and fix chaindelete * Add mock server default worker * fix service crash (#3616) * Cleanup branch param in package script (#3622) * fix crash when the expression exceed the depth (#3606) * Enhance login password check (#3629) * fix_batch_insert_problem (#3627) * filter data before batch insert * add test cases * add more testcase * add notifyStop() for metaClient (#3621) * add notifyStop() for metaClient * do clean * Fix removeSession() (#3651) Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> * Issue3373 storage exit crash (#3553) * use rcu replace thread local fix storage exit crash format address some comment * fix bug * fix bug * Fix coalesce bug (#3653) * fix coalesce * fix test * add test * add tck * fix * fix * fix * delete double check agg in where clause (#3647) Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> * fix meta crash after create space (#3660) Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com> Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com> Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com> Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com> Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>

BFS calculate depth

7ca8da3

heroicNeZha added ready for review ready-for-testing PR: ready for the CI test labels Dec 30, 2021

Sophie-Xie and others added 2 commits December 30, 2021 13:52

Merge branch 'master' into expression_depth_3

75e5324

remove debug tag

3d7018a

heroicNeZha requested a review from jievince December 30, 2021 05:54

Sophie-Xie requested a review from CPWstatic December 30, 2021 05:54

heroicNeZha requested a review from yixinglu December 30, 2021 05:55

heroicNeZha linked an issue Dec 30, 2021 that may be closed by this pull request

Limit the depth of the expression, report an error when it exceeds but not crash #3393

Closed

yixinglu reviewed Dec 30, 2021

View reviewed changes

heroicNeZha force-pushed the expression_depth_3 branch from cc3db73 to 641581f Compare December 30, 2021 09:01

Merge branch 'expression_depth_3' of github.com:heroicNeZha/nebula in…

7c4ca08

…to expression_depth_3

heroicNeZha force-pushed the expression_depth_3 branch from 641581f to 7c4ca08 Compare December 30, 2021 09:05

heroicNeZha added 4 commits December 30, 2021 17:14

remove benchmark info

938737b

fix some comments

d58878c

Merge branch 'vesoft-inc:master' into expression_depth_3

e3e86d9

Merge branch 'master' into expression_depth_3

9b0b8b0

yixinglu previously approved these changes Dec 31, 2021

View reviewed changes

czpmango reviewed Jan 3, 2022

View reviewed changes

src/graph/util/ExpressionUtils.cpp Show resolved Hide resolved

Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Jan 4, 2022

jievince previously approved these changes Jan 4, 2022

View reviewed changes

fix some comments

8957cd4

heroicNeZha dismissed stale reviews from jievince and yixinglu via 7aa7944 January 4, 2022 02:25

Merge branch 'expression_depth_3' of github.com:heroicNeZha/nebula in…

18b3605

…to expression_depth_3

heroicNeZha force-pushed the expression_depth_3 branch from 7aa7944 to 18b3605 Compare January 4, 2022 03:06

heroicNeZha added 4 commits January 4, 2022 13:59

fix parserBenchMark

0963614

Merge branch 'master' into expression_depth_3

833cce2

Merge branch 'master' into expression_depth_3

b2f0a15

Merge branch 'expression_depth_3' of github.com:heroicNeZha/nebula in…

2081785

…to expression_depth_3

heroicNeZha commented Jan 4, 2022

View reviewed changes

yixinglu previously approved these changes Jan 4, 2022

View reviewed changes

jievince previously approved these changes Jan 4, 2022

View reviewed changes

CPWstatic and others added 3 commits January 4, 2022 16:58

Merge branch 'master' into expression_depth_3

bca7516

Merge branch 'master' into expression_depth_3

af74863

fix double release

25d05ac

heroicNeZha dismissed stale reviews from jievince and yixinglu via 25d05ac January 5, 2022 07:02

heroicNeZha requested review from yixinglu and jievince January 5, 2022 07:48

jievince approved these changes Jan 5, 2022

View reviewed changes

CPWstatic approved these changes Jan 5, 2022

View reviewed changes

heroicNeZha and others added 2 commits January 5, 2022 17:29

Merge branch 'master' into expression_depth_3

2c94af1

Merge branch 'master' into expression_depth_3

efee626

yixinglu approved these changes Jan 5, 2022

View reviewed changes

yixinglu merged commit a319936 into vesoft-inc:master Jan 6, 2022

jamieliu1023 mentioned this pull request Jan 8, 2022

Weekly Report 2022-01-07 vesoft-inc/nebula-community#84

Closed

Sophie-Xie pushed a commit that referenced this pull request Jan 10, 2022

fix crash when the expression exceed the depth (#3606)

b2f0271

Sophie-Xie mentioned this pull request Feb 14, 2022

crashes after executing multiple alter tags (stable reproduction) #3889

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix crash when the expression exceed the depth #3606

fix crash when the expression exceed the depth #3606

heroicNeZha commented Dec 30, 2021 •

edited by yixinglu

Loading

yixinglu Dec 30, 2021

yixinglu Dec 30, 2021

heroicNeZha Dec 30, 2021

jievince left a comment

heroicNeZha left a comment •

edited

Loading

fix crash when the expression exceed the depth #3606

fix crash when the expression exceed the depth #3606

Conversation

heroicNeZha commented Dec 30, 2021 • edited by yixinglu Loading

What type of PR is this?

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

Release notes:

yixinglu Dec 30, 2021

Choose a reason for hiding this comment

yixinglu Dec 30, 2021

Choose a reason for hiding this comment

heroicNeZha Dec 30, 2021

Choose a reason for hiding this comment

jievince left a comment

Choose a reason for hiding this comment

heroicNeZha left a comment • edited Loading

Choose a reason for hiding this comment

without depth check

add depth check

heroicNeZha commented Dec 30, 2021 •

edited by yixinglu

Loading

heroicNeZha left a comment •

edited

Loading